fix: Support negation patterns when including/excluding files from ZIP files by nishu-murmu · Pull Request #1517 · wxt-dev/wxt

nishu-murmu · 2025-03-16T15:26:04Z

Overview

This is issue reproduction repo: https://github.com/skube/min-repro-wxt

Here is the discussion about creating this PR and more context.

This PR closes #1510

Edit from @aklinker1: You can now do things like this when zipping the extension and source code:

// wxt.config.ts

export default defineConfig({
  zip: {
    // Exclude all JSON files from your extension zip except for the manifest
    exclude: ["*.json", "!manifest.json"],
    // Include all TS files in your Firefox sources ZIP, except tests.
    includeSources: ["**/*.ts", "!**/__tests__/*.ts"],
    // Exclude all scripts except for a build script from Firefox sources ZIP
    excludeSources: ["scripts/*", "!scripts/build.sh"],
  },
})

netlify · 2025-03-16T15:26:20Z

✅ Deploy Preview for creative-fairy-df92c4 ready!

Name	Link
🔨 Latest commit	`ef8163b`
🔍 Latest deploy log	https://app.netlify.com/projects/creative-fairy-df92c4/deploys/684dedc8c9c81d00090d52af
😎 Deploy Preview	https://deploy-preview-1517--creative-fairy-df92c4.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nishu-murmu · 2025-03-17T09:14:11Z

Do I need to add some test cases for these fix?

aklinker1

Thanks for the PR! We need to add some tests around these changes:

https://github.com/wxt-dev/wxt/blob/main/packages/wxt/e2e/tests/zip.test.ts

packages/wxt/src/core/zip.ts

…o fix/zip-exclude-bang

aklinker1 · 2025-04-09T14:52:01Z

packages/wxt-demo/wxt.config.ts

+    exclude: [
+      '**/*.json', // Exclude all .json files
+      '!manifest.json', // Include manifest.json
+    ],


Hold on, I'm looking at this code now, and based on the old logic:

options?.include?.some((pattern) => minimatch(relativePath, pattern)) || !options?.exclude?.some((pattern) => minimatch(relativePath, pattern))

Couldn't you have just added mainfest.json to include, since include has priority over exclude?

Yeah, but original issue was to include this negate feature in exclude parameter. Maybe you can explain this to @skube.

Perhaps I'm not understanding something, but I don't see an include option under the zip property.

Oh yeah, there isn't.
@aklinker1 that options.includes you're mentioning is taking includeSources
that is different option.

I've added a test case.

Ah, duh 👍

aklinker1 · 2025-06-14T21:00:57Z

Sorry for the slowness, I got caught up in responding to new PRs and issues, so I lost track of this one. We'll get this merged and released now!

Gonna merge with main, checks aren't running how they should be...

pkg-pr-new · 2025-06-14T21:03:55Z

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1517

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1517

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1517

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1517

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1517

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1517

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1517

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1517

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1517

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1517

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1517

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1517

wxt

npm i https://pkg.pr.new/wxt@1517

commit: ef8163b

codecov · 2025-06-14T21:04:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.14%. Comparing base (1272e2e) to head (ef8163b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1517      +/-   ##
==========================================
+ Coverage   80.98%   81.14%   +0.15%     
==========================================
  Files         129      130       +1     
  Lines        6627     6649      +22     
  Branches     1080     1090      +10     
==========================================
+ Hits         5367     5395      +28     
+ Misses       1249     1243       -6     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aklinker1 · 2025-06-14T21:37:56Z

One more change, I'm gonna extract this to a function and use it for both include and exclude. That way we can have unit tests to cover other cases as well.

`exclude`.

github-actions · 2025-06-14T23:08:14Z

Thanks for helping make WXT better!

nishu-murmu added 2 commits March 13, 2025 13:39

feat: making negate regex pattern work in zip.exclude

0283fb9

feat: exclude files in .zip except those with a bang !

97aed7c

nishu-murmu requested review from Timeraa and aklinker1 as code owners March 16, 2025 15:26

nishu-murmu changed the title ~~feat: exclude files in .zip except those with a bang !~~ fix: exclude files in .zip except those with a bang ! Mar 16, 2025

aklinker1 requested changes Mar 29, 2025

View reviewed changes

packages/wxt/src/core/zip.ts Outdated Show resolved Hide resolved

Merge branch 'fix/zip-exclude-bang' of github.com:nishu-murmu/wxt int…

14550f5

…o fix/zip-exclude-bang

aklinker1 reviewed Apr 9, 2025

View reviewed changes

nishu-murmu added 4 commits April 10, 2025 16:12

chore: removed unused function.

1d9ebee

Merge branch 'main' of github.com:wxt-dev/wxt into fix/zip-exclude-bang

733daf1

chore: reverting code in wxt.config.ts in wxt-demo.

ac9ecbb

chore: adding tests.

628af36

aklinker1 approved these changes Jun 14, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/zip-exclude-bang

cd37b52

Extract util and add unit tests, apply util to both include and

6b1d61b

`exclude`.

aklinker1 changed the title ~~fix: exclude files in .zip except those with a bang !~~ fix: Support negation patterns when including/excluding files from ZIP Jun 14, 2025

aklinker1 changed the title ~~fix: Support negation patterns when including/excluding files from ZIP~~ fix: Support negation patterns when including/excluding files from ZIP files Jun 14, 2025

Fix lint

ef8163b

aklinker1 merged commit 9ece49d into wxt-dev:main Jun 14, 2025
18 checks passed

Uh oh!

Conversation

nishu-murmu commented Mar 16, 2025 • edited by aklinker1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

netlify bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for creative-fairy-df92c4 ready!

Uh oh!

nishu-murmu commented Mar 17, 2025

Uh oh!

aklinker1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aklinker1 Apr 9, 2025

Choose a reason for hiding this comment

Uh oh!

nishu-murmu Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

skube Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

nishu-murmu Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nishu-murmu Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

aklinker1 Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

aklinker1 commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aklinker1 commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nishu-murmu commented Mar 16, 2025 •

edited by aklinker1

Loading

netlify bot commented Mar 16, 2025 •

edited

Loading

nishu-murmu Apr 10, 2025 •

edited

Loading

aklinker1 commented Jun 14, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 14, 2025 •

edited

Loading

codecov bot commented Jun 14, 2025 •

edited

Loading

aklinker1 commented Jun 14, 2025 •

edited

Loading